Room mentioning in the composer #3868
Open
+558
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 8fcd306 |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
to scale with the room pill
to appear in the suggestions view for the RTE, however I need to add the pills to the composer and the compatibility with the plain text composer
the right suggestion type and the suggestion text properly
also updated some tests, but we need more of them
Velin92
force-pushed
the
mauroromito/room-pills-autocompletion
branch
from
03be09c to
2537c29
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering pills in the composer, alongside the auto-suggestions for them once typing the
#character.The behaviour is the same as EW, as soon as you type # you will see all the rooms with a canonical alias, and by typing more text you can filter them by searching either their name or the alias, once selecting one of the options, the room address permalink will be added to the message but rendered as a nice room pill.